Introducing histogram* bingroup attributes #3845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- design to work for histogram AND histogram2d* traces! - design to work with bingroup! - fills in fullLayout._histogramBinOpts for all histogram* traces - replace `binDir` field in histogramBinOpts[i] by `dirs` (an array) to handle cases where x and y bins are in same bingroup
This was referenced May 8, 2019
antoinerg
reviewed
May 17, 2019
antoinerg
reviewed
May 17, 2019
antoinerg
reviewed
May 17, 2019
|
Thanks for the very nice PR @etpinard ! The tests are very nice 👍 I think I have uncovered a bug (not related to your PR) when reviewing. A few mocks in your test suite do not render! I will leave it up to you to decide whether to fix this here or in another PR. Let me know what you decide to do. |
... in histogram tests as a workaround for
#3881
etpinard
added a commit
that referenced
this pull request
May 29, 2019
- this fixes some shared histogram2d (via bingroup) edge cases - this fixes a performance regression from #3845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3749 (the 1d overlay case) and resolves #3515 (the 2d case).
Users can now group traces such that their autobin settings are compatible (see #3515 (comment) for more info on what compatible means).
Examples:
In brief, this PR:
bingrouptohistogram,histogram2dandhistogram2dcontourtraceshistogram2dandhistogram2dcontourtraces also get new attributesxbingroupandybingroupto allow users to group x-bins and y-bins separately.To do so, I decided to:
crossTraceDefaultsmethodcalcAllAutoBinsroutine@plotly/plotly_js best to review this PR commit-by-commit. Starting by reviewing the jasmine tests added in 359fbbc might make things easier to grasp.