-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
d3-sankey-circular #3406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
d3-sankey-circular #3406
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
03a3cb5
merge @Plotly/d3-sankey into plotly.js (es6 -> es5, tests in jasmine)
antoinerg 2504dc3
fix header for d3-sankey.js
antoinerg fd19907
move data conversion into its own function and run in calc() phase
antoinerg bde2a79
refactor d3-sankey to look more similar to upstream
antoinerg 5f89d78
fix indentation
antoinerg 1ad9586
updating to d3-sankey 0.7.1
antoinerg ee7088a
generate link path appropriately, reattach mouse events
antoinerg 5418d25
fix dragging, snapping, pushing and pass all tests
antoinerg be1acc8
initial rough integration of d3-sankey-circular
antoinerg 067869f
implement dragging
antoinerg f8bf7fe
fallback to d3-sankey if no circularity is present
antoinerg 54523db
Merge remote-tracking branch 'origin' into sankey-circular, fix lint
antoinerg ed87295
testing features of d3-sankey-circular
antoinerg c1404fb
change stroke-opacity on hover
antoinerg d268b73
use index as unique identifier for nodes
antoinerg 09d2aa6
delete tests dealing with removal of circular nodes
antoinerg 3e5b160
on update, change circular link type based on nodes' position
antoinerg 3ed9ba5
circular-sankey, sort links per node on update
antoinerg 00e5d28
change node's identifier
antoinerg f63e2b5
update tests for Sankey generators
antoinerg 6fb3fb4
document that link.line.(width|color) is not supported with circularity
antoinerg 51085c4
add mocks and baselines for circular Sankey
antoinerg 9ca4d5d
use tomshanley/d3-circular-sankey now that our changes got merged in
antoinerg d1d852a
render circular links as closed paths
antoinerg 2382d74
update sankey_circular baseline
antoinerg 04a186c
move function defined in convert-to-d3-sankey.js into calc.js
antoinerg dee73b8
remove npm packages not used
antoinerg b3bcdd6
improve style
antoinerg 4539d28
combine all sankey tests into a single file
antoinerg 225d310
position hover label above circular links
antoinerg 9b36090
update d3-sankey-circular and test update() API
antoinerg 48a8b1b
sankey-circular: add baseline with subplots and vertical orientation
antoinerg 777dc97
update Sankey deps
antoinerg ebe613b
nest API tests for d3-sankey-circular in its own describe block
antoinerg 04d53ff
d3-sankey-circular test large dataset
antoinerg 003704c
remove gap between circular links
antoinerg 3625234
update d3-sankey-circular and associated baselines
antoinerg 59dbef4
update d3-sankey-circular deps
antoinerg 4ed7634
update dep of d3-sankey-circular
antoinerg ba2a485
Merge pull request #3535 from plotly/pr-large-sankey-circular
antoinerg 063784a
test switching to circular Sankey on Plotly.react
antoinerg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "data": [{ | ||
| "domain": { | ||
| "x": [0, 0.45] | ||
| }, | ||
| "type": "sankey", | ||
| "orientation": "h", | ||
| "node": { | ||
| "line": { | ||
| "color": "black", | ||
| "width": 1 | ||
| }, | ||
| "label": ["el1", "el2", "el3"] | ||
| }, | ||
| "link": { | ||
| "source": [0, 2, 1], | ||
| "target": [1, 1, 2], | ||
| "value": [120, 50, 30], | ||
| "color": "purple", | ||
| "label": ["stram1", "stream2", "stream3"], | ||
| "line": { | ||
| "color": "black", | ||
| "width": 1 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "domain": { | ||
| "x": [0.55, 1] | ||
| }, | ||
| "type": "sankey", | ||
| "orientation": "v", | ||
| "node": { | ||
| "line": { | ||
| "color": "black", | ||
| "width": 1 | ||
| }, | ||
| "label": ["el4", "el5", "el6", "el7", "el8"] | ||
| }, | ||
| "link": { | ||
| "source": [0, 2, 1, 3, 4, 1], | ||
| "target": [1, 1, 2, 2, 2, 4], | ||
| "value": [120, 50, 30, 70, 25, 10], | ||
| "color": "rgba(0, 0, 0, 0.1)", | ||
| "label": ["stram4", "stream5", "stream6", "stream7", "stream8", "stream9"], | ||
| "line": { | ||
| "color": "black", | ||
| "width": 1 | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "layout": { | ||
| "title": "Multiple Sankey plots with circular links", | ||
| "width": 800, | ||
| "height": 300, | ||
| "margin": { | ||
| "t": 50, | ||
| "l": 10, | ||
| "r": 10, | ||
| "b": 10 | ||
| }, | ||
| "showlegend": false | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool mock!