-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
initial implementation of layout.colorscale
#3274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6b1b940
initial implementation of `layout.colorscale`
antoinerg 0e98c5b
fix editType
antoinerg 6e61f3b
fix parcoords, fix default colorscale
antoinerg f5bcb71
do not coerce layout.colorscale if not specified
antoinerg a299ce0
move layout colorscale attributes into its own file
antoinerg 2a20414
update description for layout.colorscale attributes
antoinerg 2460fc3
fix lint
antoinerg 0c13592
change colorscaleCalc's signature, cleanup code
antoinerg 93ce241
update colorscale tests to provide a layout object to calcColorscale
antoinerg d263a7f
fix lint
antoinerg 84f0ea8
revert parcoords_tests.js to master
antoinerg ee222d5
test layout.colorscale inheritance
antoinerg 75e8910
improve code readability
antoinerg e50a6aa
add a mock using template and layout.colorscale
antoinerg dca4350
set autocolorscale: true in template to properly test mock
antoinerg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| { | ||
| "data": [{ | ||
| "x": [ | ||
| 50076, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| -65484, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| -88596, | ||
| -65484, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| 50076, | ||
| 73188, | ||
| -65484, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| 50076, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| -88596, | ||
| -65484, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| 50076, | ||
| 73188, | ||
| -88596, | ||
| -65484, | ||
| -42372, | ||
| -19260, | ||
| 3852, | ||
| 26964, | ||
| 50076, | ||
| 73188 | ||
| ], | ||
| "y": [ | ||
| 51851.8, | ||
| 77841.4, | ||
| 77841.4, | ||
| 77841.4, | ||
| 77841.4, | ||
| 51851.8, | ||
| 51851.8, | ||
| 51851.8, | ||
| 51851.8, | ||
| 51851.8, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -26117, | ||
| -52106.6, | ||
| -52106.6, | ||
| -52106.6, | ||
| -52106.6, | ||
| -52106.6, | ||
| -52106.6, | ||
| -78096.2, | ||
| -78096.2, | ||
| -78096.2, | ||
| -78096.2, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| -127.4, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2, | ||
| 25862.2 | ||
| ], | ||
| "z": [ | ||
| 4.361856, | ||
| 4.234497, | ||
| 4.321701, | ||
| 4.450315, | ||
| 4.416136, | ||
| 4.210373, | ||
| 4.32009, | ||
| 4.246728, | ||
| 4.293992, | ||
| 4.316364, | ||
| 3.908434, | ||
| 4.433257, | ||
| 4.364234, | ||
| 4.308714, | ||
| 4.275516, | ||
| 4.126979, | ||
| 4.296483, | ||
| 4.320471, | ||
| 4.339848, | ||
| 4.39907, | ||
| 4.345006, | ||
| 4.315032, | ||
| 4.295618, | ||
| 4.262052, | ||
| 4.154291, | ||
| 4.404264, | ||
| 4.33847, | ||
| 4.270931, | ||
| 4.032226, | ||
| 4.381492, | ||
| 4.328922, | ||
| 4.24046, | ||
| 4.349151, | ||
| 4.202861, | ||
| 4.256402, | ||
| 4.28972, | ||
| 3.956225, | ||
| 4.337909, | ||
| 4.31226, | ||
| 4.259435, | ||
| 4.146854, | ||
| 4.235799, | ||
| 4.238752, | ||
| 4.299876 | ||
| ], | ||
| "type": "heatmap", | ||
| "autocolorscale": true | ||
| }], | ||
| "layout": { | ||
| "template": { | ||
| "layout": { | ||
| "title": "heatmap template", | ||
| "colorscale": { | ||
| "sequential": [ | ||
| [0, "rgb(0,0,0)"], | ||
| [1, "rgb(255,255,255)"] | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we put
autocolorscale: truein thetemplatecontainer, does it still work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I modified the mock in dca4350