support 'e' and 'E' exponentformat on log axes #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Aug 17, 2018
| "size": 0, | ||
| "color": "" | ||
| }, | ||
| "exponentformat": "e", |
There was a problem hiding this comment.
@etpinard I suppose since this behavior has existed so long, this could be considered a breaking change... but it also seems to me to be clearly wrong. Are you OK with calling it a bug?
There was a problem hiding this comment.
Yes, I'm ok calling this a bug as "e" isn't the exponentformat default, so it can't happen "by accident".
etpinard
reviewed
Aug 20, 2018
| "mirror": true, | ||
| "overlaying": false, | ||
| }, | ||
| "exponentformat": "power", |
There was a problem hiding this comment.
heh yeah, sorry - I should have split out linting those trailing spaces (we don't test that in the mocks?) into its own commit.
|
Beautiful 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2919 - not sure why I thought at the time that
eandEshould be treated as synonymous withpowerbut that doesn't really make much sense.cc @etpinard