Skip to content

Faster axis autorange + remove calcIfAutorange edit type #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 2, 2018
Merged

Faster axis autorange + remove calcIfAutorange edit type #2823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c2be8d
pass dragbox element to mouseEvent
etpinard Jul 13, 2018
c9711dc
fixup "role" for ax autorange and rangemode
etpinard May 14, 2018
bd61c54
sub fail -> failTest
etpinard Jul 17, 2018
b1911b3
run Axes.expand on `autorange: false` axes
etpinard May 14, 2018
35d501d
handle splom Axes.expand calls w/ undefined xa/ya
etpinard May 28, 2018
a8fb653
adapt and :lock: annotations to 'calcIfAutorange'-less edits!
etpinard Jul 16, 2018
6e19c6e
remove unused '_' fields in annotations full items
etpinard Jul 17, 2018
4e8ff28
:lock: marker.size calc + autorange edit behavior
etpinard Jul 17, 2018
c75cda8
swap and :lock: 'calcIfAutorange' -> 'calc' for shapes
etpinard Jul 17, 2018
8f23ef5
swap and :lock: 'calcIfAutorange' -> 'calc' for box attributes
etpinard Jul 17, 2018
a326778
fix and :lock: ohlc tickwidth edits
etpinard Jul 17, 2018
138a84f
:hocho: calcIfAutorange logic in Plotly methods
etpinard Jul 17, 2018
1c40947
try ax autorange as 'axrange' edit type
etpinard Jul 17, 2018
026cd53
lint / fix comment
etpinard Jul 18, 2018
1cdc36b
:hocho: obsolete _rangesliderAutorange field
etpinard Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plots/cartesian/autorange.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ function doAutoRange(ax) {
* and make it a tight bound if possible
*/
function expand(ax, data, options) {

if(!ax._min) ax._min = [];
if(!ax._max) ax._max = [];
if(!options) options = {};
Expand Down
5 changes: 3 additions & 2 deletions src/traces/scatter/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ function calcAxisExpansion(gd, trace, xa, ya, x, y, ppad) {
yOptions.padded = false;
}

Axes.expand(xa, x, xOptions);
Axes.expand(ya, y, yOptions);
// N.B. asymmetric splom traces call this with undefined xa or ya
Copy link
Collaborator

@alexcjohnson alexcjohnson Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not undefined, that would error here as well as above... it's {}

Copy link
Contributor Author

@etpinard etpinard Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch -> 026cd53

if(xa._id) Axes.expand(xa, x, xOptions);
if(ya._id) Axes.expand(ya, y, yOptions);
}

function calcMarkerSize(trace, serieslen) {
Expand Down