Skip to content

Fix box & violin inner parts removal #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2018
Merged

Fix box & violin inner parts removal #2785

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
611581c
sub fail -> failTest
etpinard Jul 5, 2018
47349c7
fix box line/pts removal
etpinard Jul 5, 2018
4e48cd7
fix violin box/meanline/pts removal
etpinard Jul 5, 2018
b2a55f6
fixup new box.plot logic for candlestick
etpinard Jul 5, 2018
1e4900c
cleanup logic for data-bind fn / fallback to []
etpinard Jul 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/traces/box/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ function plotBoxAndWhiskers(sel, axes, trace, t) {

var fn;
if(trace.type === 'box' ||
trace.type === 'candlestick' ||
Copy link
Collaborator

@alexcjohnson alexcjohnson Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps trace.type !== 'violin' || trace.box? NBD either way, we'd of course figure it out pretty quick if we add any other trace type that reuses box drawing.

(trace.type === 'violin' && (trace.box || {}).visible)
) {
fn = Lib.identity;
Expand Down