Skip to content

Scattergl transform fixes #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2018
Merged

Scattergl transform fixes #2677

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c52fbe7
fix #2671 - fix transform on 'scattergl' traces
etpinard May 28, 2018
9055d49
do not scale scattergl line.width by marker.sizeref
etpinard May 28, 2018
187a155
make scattergl [un]selected.marker.size scale properly
etpinard May 28, 2018
56c8058
add transform and point-selection mocks of scattergl traces
etpinard May 28, 2018
b85ffe2
sub fail -> failTest
etpinard May 29, 2018
86d6a95
:lock: scattergl transform behavior
etpinard May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/traces/scattergl/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,10 @@ function convertMarkerStyle(trace) {
// See https://github.com/plotly/plotly.js/pull/1781#discussion_r121820798
if(multiLineWidth) {
for(i = 0; i < count; i++) {
borderSizes[i] = markerSizeFunc(optsIn.line.width[i]);
borderSizes[i] = optsIn.line.width[i] / 2;
}
} else {
s = markerSizeFunc(optsIn.line.width);
s = optsIn.line.width / 2;
Copy link
Contributor Author

@etpinard etpinard May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this commit, gl2d_transforms looked like:

image

for(i = 0; i < count; i++) {
borderSizes[i] = s;
}
Expand Down