Skip to content

Scattergl selection / clustering fix #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 1, 2018
Merged

Scattergl selection / clustering fix #2593

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f0b9ee3
Bump versions
dy Apr 30, 2018
10f8323
Bump scattergl
dy Apr 30, 2018
1e31584
Fix scattergl errors
dy Apr 30, 2018
b0df167
Fix baseline
dy Apr 30, 2018
cefb88f
Fix safari regl-line2d and regl-error2d
dy May 1, 2018
bf9d234
Add continuous data baseline
dy May 1, 2018
dbd6049
Fix point-cluster
dy May 1, 2018
7492c2f
Bump splom safari
dy May 1, 2018
7ad487f
Fix clustering baseline
dy May 1, 2018
f68d15e
Fix all colors
dy May 1, 2018
412a798
Fix mock syntax
dy May 1, 2018
b78f320
Bump splom & add baseline
dy May 1, 2018
f7dc6b3
add test for splom with typed array values
etpinard May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/jasmine/tests/splom_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,21 @@ describe('@gl Test splom interactions:', function() {
.catch(failTest)
.then(done);
});

it('should work with typed arrays', function(done) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locking a fix for #2585 from the new regl-splom version

Plotly.plot(gd, [{
type: 'splom',
dimensions: [{
label: 'A',
values: new Int32Array([1, 2, 3])
}, {
label: 'B',
values: new Int32Array([2, 5, 6])
}]
}])
.catch(failTest)
.then(done);
});
});

describe('@gl Test splom hover:', function() {
Expand Down