Skip to content

Relink less stuff #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 16, 2018
Merged

Relink less stuff #2375

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d540e
don't relink customdata, ids, or any matching objects
alexcjohnson Feb 16, 2018
1723ed8
update style in relinkPrivateKeys
alexcjohnson Feb 16, 2018
3e22d38
mock out createObjectURL for makeSchema task
alexcjohnson Feb 16, 2018
5a3d2a6
tighten array handling in relinkPrivateKeys
alexcjohnson Feb 16, 2018
62e54b7
comment about making `ids` be strings only
alexcjohnson Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tasks/util/make_schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = function makeSchema(plotlyPath, schemaPath) {
// package is annoying and platform-dependent.
// see https://github.com/tmpvar/jsdom/issues/1782
w.HTMLCanvasElement.prototype.getContext = function() { return null; };
w.URL.createObjectURL = function() { return null; };
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard npm run build works again with this change.

Copy link
Contributor

@etpinard etpinard Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!


w.eval(plotlyjsCode);

Expand Down