-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Aggregate transforms #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Aggregate transforms #1924
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bcc0ca1
use beforeEach(createGraphDiv) pattern in transform_multi
alexcjohnson 95aa244
axes.getDataConversions as a generalization of axes.getDataToCoordFunc
alexcjohnson 9e83747
aggregate transform
alexcjohnson 317938f
lint
alexcjohnson ffc4ee2
aggregations.array -> target
alexcjohnson 6d2d32c
aggregations[i].enabled
alexcjohnson b6ccc01
more aggregate functions
alexcjohnson 572f282
sample vs population stddev
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all the discussion, I felt compelled to verify the formula, though I really do trust it's correct. But anyway, I ran it against a simple online calculator and copied the function into a super quick test: https://gist.github.com/rreusser/ffe0a6cea78dd153c6eea1d54ac11ea1
It gets a hearty 👍 from me. 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, make that 💃