Skip to content

Misc perf improvements #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 11, 2017
Merged

Misc perf improvements #1772

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
032cf7c
get rid of Lib.getPlotDiv
alexcjohnson Jun 7, 2017
c02204f
short-circuit title draw if there's no title
alexcjohnson Jun 7, 2017
b4a2f4d
drop the unneeded initial draw of axes
alexcjohnson Jun 7, 2017
b9c33c9
add perf tester to global scope in test dashboard
alexcjohnson Jun 9, 2017
ea883e6
cache bounding boxes by node contents instead of by data-bb attr
alexcjohnson Jun 9, 2017
11f4a0e
Merge branch 'master' into misc-perf
alexcjohnson Jun 9, 2017
a511bd2
clear bbox cache to fix bar test
alexcjohnson Jun 9, 2017
434dc0e
standardize fail logic in bar test
alexcjohnson Jun 9, 2017
d077e32
more failure info in cartesian_interact_test
alexcjohnson Jun 9, 2017
3132624
cleanup cartesian_interact_test a little
alexcjohnson Jun 9, 2017
00c7ad5
remove unused dragElement.init option 'doubleclick'
alexcjohnson Jun 10, 2017
2da3544
cleaner delay pattern in pan tester
alexcjohnson Jun 10, 2017
dc4fc32
robustify cartesian_interact_test doubleclicker
alexcjohnson Jun 10, 2017
0129d5a
simplify dragElement cursor handling & remove redundant initInteractions
alexcjohnson Jun 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/jasmine/tests/cartesian_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,10 @@ describe('axis zoom/pan and main plot zoom', function() {
}

function doDblClick(subplot, directions) {
return function() { return doubleClick(getDragger(subplot, directions)); };
return function() {
gd._mouseDownTime = 0; // ensure independence from any previous clicks
return doubleClick(getDragger(subplot, directions));
};
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Jun 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this one was brutal - the key was that (locally, in chrome, when running multiple tests) it was seeing a previous click (from the same test, despite the fact that it still cared whether another test had been run before this one) too close to the first click of the doubleclick, and ended up responding as if there were two doubleclicks - which I still don't quite understand, I didn't think a triple-click would look like two doubles, but anyway this works and we can use this in the future (similar to your trick with gd._lastHoverTime @etpinard ) to cut down on unnecessary delays in the test suite.

For future reference @etpinard since we talked about potentially doing this, I went off on a dead end for a while when I noticed that calling Plotly.purge(gd) during destroyGraphDiv caused all sorts of problems... That turns out to be unrelated, that sometimes there are some things still waiting to happen on the plot after tests have finished (like rehover) which will fail (and confusingly attribute the failure to the next test that's run, since it's happening async) if we've purged the plot of attributes like emit but they still complete without failure if all we've done is remove the gd from the DOM.

Copy link
Contributor

@etpinard etpinard Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing down the details.

Copy link
Contributor

@etpinard etpinard Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

🎉 nice work

}

function checkRanges(newRanges, msg) {
Expand Down