Don't try to draw spikeline if the axis isn't on the chart. #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I'm not convinced this is the desired behavior (even though this patch clears some console errors). I can see spikes on invisible axes being somewhat useful (?) |
|
Nice catch @rpaskowitz! But I think @etpinard is right, we should find a way to still show the spikes. Particularly in I propose that if the axis is invisible, we act as though it would have been at the farthest left/bottom of all subplots it's used in. Sound reasonable? |
|
Yeah, given the use of comparing data points, still drawing the line makes sense. |
This was referenced Sep 1, 2017
|
Will be fixed in #1980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the line wasn't being drawn and errors were being logged to console on the last chart at https://plot.ly/javascript/line-charts/. This should clean that up.