Skip to content

More scattergl symbols #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

More scattergl symbols #1482

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb092cf
Add 49 more unicode symbols for scattergl symbol types
Mar 15, 2017
ffad7fa
revert devtools folder to master
Mar 16, 2017
4c2929a
Merge branch 'master' into scattergl-on-par-shapes
Mar 16, 2017
2bee6b2
Merge branch 'master' into scattergl-on-par-shapes
Mar 21, 2017
c0eb065
Changed gl_marker 'cross' back to original symbol and ran npm lint-fix
Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/constants/gl_markers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = {
'square-open': '□',
diamond: '◆',
'diamond-open': '◇',
cross: '➕',
cross: '+',
Copy link
Author

@destradafilm destradafilm Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed cross back to original symbol, so that means I removed 'cross-thin'

Copy link
Contributor

@etpinard etpinard Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Reverting back to the current symbol is the way to go here.

That said, we could (and should I'd say) make cross thicker and add cross-thin in v2.

Copy link
Contributor

@etpinard etpinard Apr 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the #420 list of planned breaking changes.

x: '❌',
'triangle-up': '▲',
'triangle-up-open': '△',
Expand Down Expand Up @@ -52,6 +52,5 @@ module.exports = {
'circle-x': '⊗',
'square-cross': '⊞',
'square-x': '⊠',
'cross-thin': '+',
'asterisk': '✱'
};
};