Skip to content

Fix shapes and images referencing a missing subplot #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2017
Merged

Fix shapes and images referencing a missing subplot #1481

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd62f54
fix images and shapes that reference missing subplots
alexcjohnson Mar 15, 2017
7146543
clean up image sources to avoid extraneous log messages
alexcjohnson Mar 15, 2017
9369bc3
:hocho: commented-out code
alexcjohnson Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/jasmine/tests/layout_images_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('Layout images', function() {
it('should draw images on the right layers', function() {

Plotly.plot(gd, data, { images: [{
source: 'imageabove',
source: jsLogo,
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Mar 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were generating 404 warnings when you run the tests, which seem distracting and unnecessary, so I just put in jsLogo everywhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch 👌

layer: 'above'
}]});

Expand All @@ -116,7 +116,7 @@ describe('Layout images', function() {
destroyGraphDiv();
gd = createGraphDiv();
Plotly.plot(gd, data, { images: [{
source: 'imagebelow',
source: jsLogo,
layer: 'below'
}]});

Expand All @@ -125,7 +125,7 @@ describe('Layout images', function() {
destroyGraphDiv();
gd = createGraphDiv();
Plotly.plot(gd, data, { images: [{
source: 'imagesubplot',
source: jsLogo,
layer: 'below',
xref: 'x',
yref: 'y'
Expand Down Expand Up @@ -162,9 +162,9 @@ describe('Layout images', function() {
describe('with anchors and sizing', function() {

function testAspectRatio(xAnchor, yAnchor, sizing, expected) {
var anchorName = xAnchor + yAnchor;
// var anchorName = xAnchor + yAnchor;
Plotly.plot(gd, data, { images: [{
source: anchorName,
source: jsLogo,
xanchor: xAnchor,
yanchor: yAnchor,
sizing: sizing
Expand Down Expand Up @@ -430,7 +430,7 @@ describe('images log/linear axis changes', function() {
],
layout: {
images: [{
source: 'https://images.plot.ly/language-icons/api-home/python-logo.png',
source: pythonLogo,
x: 1,
y: 1,
xref: 'x',
Expand Down