Skip to content

Remove all event listeners from gd #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2015
Merged

Remove all event listeners from gd #117

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5621969
Remove all event listeners from gd
mdtusz Dec 15, 2015
6e21c47
Moved `removeAllListeners` and added existence check
mdtusz Dec 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,7 @@ Plotly.redraw = function(gd) {
Plotly.newPlot = function (gd, data, layout, config) {
gd = getGraphDiv(gd);
plots.purge(gd);
gd.removeAllListeners();
Copy link
Contributor

@etpinard etpinard Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd would put this in plots.purge

and maybe (cc @alexcjohnson ) we could expose purge on Plotly? It sounds to me like something users might want to use.

Copy link
Contributor Author

@mdtusz mdtusz Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on moving removeAllListeners. Not sure if we should expose the purge method though - I can't think of too many use cases where that's what a user would want to clear the node and reuse it - if they want to "purge", they'll just delete the node. Better to keep the user surface area of plotly.js as small as possible.

@alexcjohnson thoughts?

Copy link
Contributor

@etpinard etpinard Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdtusz

if they want to "purge", they'll just delete the node.

You got me convinced 👍

Copy link
Contributor Author

@mdtusz mdtusz Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purge it all

return Plotly.plot(gd, data, layout, config);
};

Expand Down