-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Mapbox-gl requires outdated package #1714
Comments
Yep it's breaking our tests, see #1543 |
I came here via
#1543 indicates that "[email protected] does not get along with the nw.js version we use in our image test container" and "I couldn't update mapbox-gl to their latest version (v0.34.0) because that version is currently broken in browserified bundles and that patch hasn't been published yet." But that comment was written 1 April and mapbox/mapbox-gl-js#4486 AFAIK has since been released in v0.35.0. So...is there still blocker for this? I'm not familiar with how you're testing with nw.js to try and replicate on my end. |
Thanks @eddies for writing in. By quickly looking at the
If you're down to try, reading through this and this should be enough to get you started. Now that |
I'm not sure I'm seeing the same issue but installing plotly seems to require serveral mapbox packages from github that don't exist. Any known solution to this? |
Since this older version of mapbox-gl is a dependency, it might be better to make a copy of it somewhere the package managers can reference. |
Especially because npm is wasting lots of time trying to resolve those dependencies, and in CI scenarios it's less than ideal |
The package requires an outdated node-zlib-backports package, which could easily be solved by changing:
"mapbox-gl": "^0.22.0",
to
"mapbox-gl": "^0.37.0",
Could anyone test if this results in breaking changes, as for my use case it worked flawlessly.
The text was updated successfully, but these errors were encountered: