Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Mapbox-gl requires outdated package #1714

Closed
g4challenge opened this issue May 23, 2017 · 6 comments · Fixed by #2361
Closed

Dependency Mapbox-gl requires outdated package #1714

g4challenge opened this issue May 23, 2017 · 6 comments · Fixed by #2361

Comments

@g4challenge
Copy link

The package requires an outdated node-zlib-backports package, which could easily be solved by changing:

"mapbox-gl": "^0.22.0",

to

"mapbox-gl": "^0.37.0",

Could anyone test if this results in breaking changes, as for my use case it worked flawlessly.

@etpinard
Copy link
Contributor

Yep it's breaking our tests, see #1543

@eddies
Copy link

eddies commented Jun 1, 2017

I came here via

#1543 indicates that "[email protected] does not get along with the nw.js version we use in our image test container" and "I couldn't update mapbox-gl to their latest version (v0.34.0) because that version is currently broken in browserified bundles and that patch hasn't been published yet."

But that comment was written 1 April and mapbox/mapbox-gl-js#4486 AFAIK has since been released in v0.35.0.

So...is there still blocker for this? I'm not familiar with how you're testing with nw.js to try and replicate on my end.

@etpinard
Copy link
Contributor

etpinard commented Jun 1, 2017

Thanks @eddies for writing in. By quickly looking at the mapbox-gl changelog, I don't anything that would fix its issues with the (old) nw.js version we use to run our image tests. So, I doubt that bumping mapbox-gl to v0.35.0 would fix our issues.

I'm not familiar with how you're testing with nw.js to try and replicate on my end.

If you're down to try, reading through this and this should be enough to get you started.


Now that npm@5 is the npm's latest version, issue #1745 becomes very problematic for us. We're planning on improving our image test runner in the coming months, but that might be too long of a wait. I'm thinking we should fork mapbox-gl and publish it as @plotly/mapbox-gl on npm in such a way that npm@5 does not complain when installing.

@simoneb
Copy link

simoneb commented Oct 13, 2017

I'm not sure I'm seeing the same issue but installing plotly seems to require serveral mapbox packages from github that don't exist. Any known solution to this?

@jeberst
Copy link

jeberst commented Oct 13, 2017

Since this older version of mapbox-gl is a dependency, it might be better to make a copy of it somewhere the package managers can reference.

@simoneb
Copy link

simoneb commented Oct 13, 2017

Especially because npm is wasting lots of time trying to resolve those dependencies, and in CI scenarios it's less than ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants