Skip to content

Add support for alternative axis sides in ggplotly #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Add support for alternative axis sides in ggplotly #813

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1ae04af
Add support for alternative axis sides in ggplotly
alanocallaghan Nov 23, 2016
bb7e07b
DRY - remove redundant assignment
alanocallaghan Nov 24, 2016
b5bbc2a
Add axis test, refactor axis movement code
alanocallaghan Nov 26, 2016
369b760
Add bottom/left test
alanocallaghan Nov 27, 2016
94ce05b
Add default axis code
alanocallaghan Nov 27, 2016
4edf8e8
Fix test message
alanocallaghan Nov 27, 2016
21c5712
Fix error
alanocallaghan Feb 8, 2017
4379260
Fix merge conflict and test error
alanocallaghan Feb 8, 2017
cbd3077
Move anchor when non-standard axis position
alanocallaghan Feb 21, 2017
304a1ab
Move ticks above facet labels when non-standard
alanocallaghan Feb 21, 2017
ebb135c
Fix merge conflict
alanocallaghan Feb 21, 2017
b82036d
Fix axis text rotation
alanocallaghan Feb 21, 2017
92ba0eb
add tests
alanocallaghan Feb 22, 2017
31c21c4
Fix typo in tests
alanocallaghan Feb 22, 2017
f08fc47
Fix breaking tests
alanocallaghan Feb 22, 2017
347cd3e
Fix broken tests
alanocallaghan Feb 22, 2017
00f5bda
Fix final broken test
alanocallaghan Feb 22, 2017
d3527db
Remove comment and add explanation
alanocallaghan Feb 22, 2017
1a3941e
Add code to pad properly for axis movement
alanocallaghan Mar 9, 2017
1f6a55e
Tweak ticklen
alanocallaghan Mar 9, 2017
523a860
Merge with master
Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,8 @@ gg2list <- function(p, width = NULL, height = NULL,
if (xy == "x") {
## Facet labels are always on top, so add tick length to move past them
axisObj[["ticklen"]] <- axisObj[["ticklen"]] +
(unitConvert(stripText, "pixels", type) * 2.5)
(unitConvert(stripText, "pixels", type) * 3)
Copy link
Contributor Author

@alanocallaghan alanocallaghan Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a magic number. I don't think ticklen can vary dynamically so it has to be large enough to accomodate large and small window sizes. It'll be too long for small window sizes but if it's extreme the user can adjust it using p %>% layout(xaxis=list(ticklen=10), xaxis2=list(ticklen=10), ...).

I'll log an issue on the plotly.js github to see if it would be possible to have ticklen optionally be a proportion of the plot rather than strictly pixels, but otherwise it's a necessary evil


axisObj[["anchor"]] <- "y"
} else if (xy == "y" && nCols > 1) {
axisObj[["anchor"]] <- paste0("x", nCols)
Expand Down