Fixes set_props to merge instead of overwriting props#3182
Closed
Raahul-Singh wants to merge 1 commit into
Closed
Conversation
T4rk1n
reviewed
Feb 24, 2025
Contributor
T4rk1n
left a comment
There was a problem hiding this comment.
This is only for diskcache, we need the same behavior in regular callbacks, diskcache and celery.
Also need to add tests for the merging.
Contributor
|
Would be interesting to see if this could take on a behaviour of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!
Fixes #3104
Contributor Checklist
_set_propsinside_make_job_fnto accumulate updates instead of overwriting.set_propscalls persist across multiple updates.set_propscalls in a background callback to confirm the fix.optionals
CHANGELOG.mdned the relevant URLS as follows
- [ ] this GitHub #PR number updates the dash docs
- [ ] here is the show and tell thread in Plotly Dash community
This change gets the expected behavior in @faulty13' snippet
Screen.Recording.2025-02-21.at.11.36.25.PM.mov