Skip to content

Support debug=True if native namespace-packages are present #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Jan 28, 2022
Merged

Support debug=True if native namespace-packages are present #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15b3e95
Support debug=True if namespace-packages are present
Jan 20, 2022
6f97dc3
Added changelog entry, disable protected-access linting to _path
Jan 28, 2022
4662a09
Merge branch 'dev' into lschmelting-dev
alexcjohnson Jan 28, 2022
eb85b76
black
alexcjohnson Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- [#1778](https://github.com/plotly/dash/pull/1778) DataTable: Fix React warnings stating
that each child in a list should have a unique "key" prop

- [#1895](https://github.com/plotly/dash/pull/1895) Support debug=True if native namespace-packages are present

## [2.0.0] - 2021-08-03

## Dash and Dash Renderer
Expand Down
8 changes: 7 additions & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,12 +1731,18 @@ def enable_dev_tools(
if isinstance(package, ModuleSpec)
else os.path.dirname(package.path)
if hasattr(package, "path")
else os.path.dirname(
package._path[0] # pylint: disable=protected-access
)
if hasattr(package, "_path")
else package.filename
for package in packages
]

for i, package in enumerate(packages):
if "dash/dash" in os.path.dirname(package.path):
if hasattr(package, "path") and "dash/dash" in os.path.dirname(
package.path
):
component_packages_dist[i : i + 1] = [
os.path.join(os.path.dirname(package.path), x)
for x in ["dcc", "html", "dash_table"]
Expand Down