Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Remove graph config innards from defaultProps #515

Merged
merged 7 commits into from
Apr 9, 2019
Merged

Remove graph config innards from defaultProps #515

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3521da0
remove Graph.defaultProps.config innards
alexcjohnson Apr 9, 2019
9e8f451
rebuild
alexcjohnson Apr 9, 2019
d4df7cc
changelog entry for graph config fix
alexcjohnson Apr 9, 2019
071b11c
fix format
Apr 9, 2019
55f45d2
test some stuff about plotly.js vs Graph
alexcjohnson Apr 9, 2019
970c682
lint
alexcjohnson Apr 9, 2019
802a9c0
capitalize some propTypes docstrings - and add one missing one
alexcjohnson Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ def on_click(n_clicks):
def check_plotlyjs(self):
# find plotly.js files in the dist folder, check that there's only one
all_dist = os.listdir(dcc.__path__[0])
js_re = '^plotly-(.*)\.min\.js$'
js_re = r'^plotly-(.*)\.min\.js$'
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oddly I can't get this error to appear locally... 😐

plotlyjs_dist = [fn for fn in all_dist if re.match(js_re, fn)]

self.assertEqual(len(plotlyjs_dist), 1)
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how we ended up with 2 copies of plotly.js on master, 1.44.1 and 1.45.0... the associated PRs all seem to swap one file for another, maybe a mis-merge somewhere. But anyway this test will prevent that in the future.

Expand Down