Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added link_method parameter #589

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Added link_method parameter #589

merged 4 commits into from
Nov 4, 2021

Conversation

nickmelnikov82
Copy link
Member

Closes #578

About

  • I am closing an issue
  • This is a new component
  • I am adding a feature to an existing component, or improving an existing feature

Description of changes

Added link_method parameter to configure linking algorithm if link_fun is not set.

HammadTheOne
HammadTheOne approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💃

My only suggestions are to add a CHANGELOG entry and a basic test for the link_method and this will be ready to merge.

@HammadTheOne HammadTheOne merged commit 3bf2ae9 into master Nov 4, 2021
@HammadTheOne HammadTheOne deleted the clustergram-improvements branch November 4, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadTheOne HammadTheOne HammadTheOne approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clustergram: Why is complete linkage hard-coded?
2 participants
@nickmelnikov82 @HammadTheOne