Update demos and contributing #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
Co-authored-by: Alex Johnson <[email protected]>
|
@alexcjohnson Does this PR require any further changes? |
|
|
||
| If you have made changes to the JS code, then you need to rebuild the package: | ||
|
|
||
| ```bash | ||
| npm run build | ||
| npm run build:all |
There was a problem hiding this comment.
Not for this PR but just because I'm noticing it: unless we already have one, please make an issue to update our package scripts for dash-bio, using perhaps dcc as a model: there should only be three build scripts: build:js, build:backends (builds Py, R, and Jl using dash-generate-components, no python -c, no get_version_info.py), and build to combine them. Assuming our source mapping is set up correctly there is no reason for build:dev or build:js-dev.
alexcjohnson
approved these changes
Apr 19, 2021
This was referenced Apr 19, 2021
|
How wonderful to know that data visualization is key to bring about changes and charts in images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518
About
Description of changes
Updated CONTRIBUTING.md and general demo app structure to make it easier for community contributors to run and develop their own Dash Bio demo apps. This PR also has some general housekeeping to remove obsolete code/directories from the days of an independent Dash Bio gallery which is no longer necessary since all demo apps are hosted on the main gallery off the
dash-sample-appsmonorepo.