Add igv component #537
Merged
Add igv component #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
When you add docs for this, can you please also add docs for dash-ngl at the same time, since it never got documented over at https://dash.plotly.com/dash-bio |
src/lib/fragments/Igv.react.js
Outdated
| */ | ||
| export default class Igv extends Component { | ||
| componentDidMount() { | ||
| var igvContainer = document.getElementById(this.props.id); |
There was a problem hiding this comment.
Don't use getElementById - use a ref instead. For an example, see https://github.com/plotly/dash-core-components/pull/604/files where this change was made to dcc.Graph
There was a problem hiding this comment.
Changed in 0e650d0.
alexcjohnson
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes plotly/dash-core#250
About
Description of changes
This PR is a continuation of the draft PR created by @shday here. This PR includes the following additions to the original PR:
igv.react.jsto enable async loading of the component and greatly reduce bundle size.app.get_asset_urlto pass a URL directly to the IGV browser.igvpackage from experimentalreactfork to (nowreact) compatiblemasterfork.