Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first draft of FornaContainer component. #418
Add first draft of FornaContainer component. #418
Changes from 1 commit
14ff1d7
7702d2e
71e872d
f4829e3
112ec28
ea1451c
e25d12f
aaad47e
a21bea9
3d126ea
63d7224
9a731d8
fd272ea
d01a200
524232d
0cc040a
f8a4f1b
dba202a
ed2005f
5322933
ab35ecf
f726054
56a44c8
0654538
3537b31
a965b1a
32d3dcf
82e6a48
775dc78
b17d6f1
4f91108
de68e61
040d781
07a1173
942daab
39a25bd
04dbdd5
edf88d4
9b3527b
e1a6b24
7e3bc68
9411e5d
ef225b1
afbc06b
3745fd9
9c5aedb
b83ebe3
04faf48
a627320
45c73c7
8f4f572
7f5df65
877f3e9
1aac6b3
7ecfc19
52db7f0
4af466d
b890bb5
2f6e424
548260e
f795f39
69dc7b1
cf6bd8f
e1eb149
7b267a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading this right,
FornaContainer
can accept either a selector string or a DOM node (it's just getting passed tod3.select
). If you use aref
and pass that instead of'#' + id
, then id becomes optional, making it easier to use and more robust.