Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashbio tests refactoring #411

Merged
merged 52 commits into from
Sep 23, 2019
Merged

Dashbio tests refactoring #411

merged 52 commits into from
Sep 23, 2019

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Aug 1, 2019

Closes #103 (finally!)

Closes #416.

About

  • This is a new component
  • I am adding a feature to an existing component, or improving an existing feature
  • I am closing an issue

Description of changes

  • Add new Python test suite that uses dash[testing] for integration tests for all components
  • Add initial boilerplate code for unit tests (to be completed in a later PR; right now, the tests only check whether or not the JS elements render)
  • Add Percy integration
  • Fix some bugs in components (see CHANGELOG updates in d6a8bf5)

Still remaining to complete (in future PRs):

  • Add more unit tests for JS components
  • Capture canvas elements (they are not included in the DOM, so they are not captured by Percy)

Before merging

@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 1, 2019 16:15 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 1, 2019 20:32 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 1, 2019 20:50 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 2, 2019 16:52 Inactive
@shammamah-zz shammamah-zz mentioned this pull request Aug 2, 2019
6 tasks
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 2, 2019 17:06 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 2, 2019 21:09 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 7, 2019 17:59 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 7, 2019 18:50 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 7, 2019 18:53 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 9, 2019 16:45 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 9, 2019 16:46 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 9, 2019 16:46 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 9, 2019 16:47 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 15, 2019 22:01 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 15, 2019 22:33 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 15, 2019 22:34 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 15, 2019 22:38 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 15, 2019 22:51 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 16, 2019 16:14 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 16, 2019 18:08 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 August 16, 2019 18:10 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 19, 2019 14:21 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 19, 2019 17:26 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 19, 2019 17:34 Inactive
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remaining comments + Byron's comments about the webdriver / require should be addressed.

@mkcor mkcor mentioned this pull request Sep 23, 2019
3 tasks
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 23, 2019 16:42 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 23, 2019 17:10 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-411 September 23, 2019 17:31 Inactive
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@shammamah-zz shammamah-zz merged commit 447ebbe into master Sep 23, 2019
@shammamah-zz shammamah-zz deleted the dashbio-tests-refactoring branch September 23, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants