-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashbio tests refactoring #411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 2, 2019 16:52
3885919
to
c705956
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 7, 2019 18:49
47250d3
to
a729a53
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 7, 2019 18:53
a729a53
to
2ae589c
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 9, 2019 16:46
32def13
to
4770c51
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 9, 2019 16:46
4770c51
to
1159f5b
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 9, 2019 16:47
1159f5b
to
dedc604
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 15, 2019 22:33
8c8e4b6
to
46f2988
Compare
shammamah-zz
force-pushed
the
dashbio-tests-refactoring
branch
from
August 16, 2019 18:10
1a725c3
to
6d498b1
Compare
Remove eslint rule that checks for no-undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remaining comments + Byron's comments about the webdriver / require should be addressed.
Co-Authored-By: Marc-André Rivet <[email protected]>
Marc-Andre-Rivet
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103 (finally!)
Closes #416.
About
Description of changes
dash[testing]
for integration tests for all componentsStill remaining to complete (in future PRs):
Before merging