Fixed folder contents issues with persistent selection #6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
avoinea
approved these changes
Dec 23, 2024
davisagli
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
This is a nasty one -- I agree it's a bad bug to keep the selection without any UI indication that there are still items selected from a previous page. Let's fix that, and if we do need a way to select across multiple pages, let's handle that as a separate UX design discussion.
pnicolli
added a commit
to collective/volto-contents-next
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5209
Closes #5931
Reset the selection when navigating, when changing page and when sorting items.
The idea is basically to reset the selection when you could have selected items that are now shown on the page.
I left one case where this is possible, but I am open for discussion about it: since the default page size is 50, a user might want to filter the contents using the text filter in the top right corner to find items in a quicker way, while still keeping the multiselection. What do you think?