Show preview image in folder content on hover #6551
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Show preview image in folder contents view on hover @iRohitSingh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,13 @@ | |
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { | ||
| Button, | ||
| Table, | ||
| Menu, | ||
| Divider, | ||
| Popup as SemanticUiPopup, | ||
| } from 'semantic-ui-react'; | ||
| import { Link } from 'react-router-dom'; | ||
| import PropTypes from 'prop-types'; | ||
| import map from 'lodash/map'; | ||
|
|
@@ -97,6 +103,8 @@ export const ContentsItemComponent = ({ | |
| order, | ||
| }) => { | ||
| const intl = useIntl(); | ||
| const previewImageUrl = `${item['@id']}/${item.image_scales?.image?.[0]?.scales?.teaser?.download}`; | ||
| const previewIconUrl = `${item['@id']}/${item.image_scales?.image?.[0]?.scales?.thumb?.download}`; | ||
|
|
||
| return connectDropTarget( | ||
| connectDragPreview( | ||
|
|
@@ -156,14 +164,41 @@ export const ContentsItemComponent = ({ | |
| to={`${item['@id']}${item.is_folderish ? '/contents' : ''}`} | ||
| > | ||
| <div className="expire-align"> | ||
| {item['@type'] === 'Image' ? ( | ||
|
There was a problem hiding this comment. All of @tisto advice is quite valid, lazy loaded when needed, you don't want to load 100 images if you never even interact with them. |
||
| <SemanticUiPopup | ||
| trigger={ | ||
| <div className="preview-image-container"> | ||
| <img | ||
| className="popup-image-icon" | ||
| src={previewIconUrl} | ||
| alt="" | ||
| />{' '} | ||
| <span title={item.title}> {item.title}</span> | ||
| </div> | ||
| } | ||
| > | ||
| <SemanticUiPopup.Content> | ||
| <div> | ||
| <img | ||
| className="popup-preview-image" | ||
| src={previewImageUrl} | ||
| alt="" | ||
| /> | ||
| </div> | ||
| </SemanticUiPopup.Content> | ||
| </SemanticUiPopup> | ||
| ) : ( | ||
| <div className="preview-image-container"> | ||
| <Icon | ||
| name={getContentIcon(item['@type'], item.is_folderish)} | ||
| size="20px" | ||
| className="icon-margin" | ||
| color="#878f93" | ||
| title={item['Type'] || item['@type']} | ||
| /> | ||
| <span title={item.title}> {item.title}</span> | ||
| </div> | ||
| )} | ||
| </div> | ||
| {item.ExpirationDate !== 'None' && | ||
| new Date(item.ExpirationDate).getTime() < | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iRohitSingh this lookup should be added in a new component that can be placed in this file
which is called if the item type is image. Right now you would attempt to check this for everything
even if there is no need for it.