Use make targets in the README development instructions - #54
Merged
Conversation
Replace the raw pnpm commands documented in the README with their make equivalents, and add the stdio, inspector and test-all targets that were missing from the Makefile. The stale 'pnpm run dev' and 'pnpm run inspector' commands are dropped: neither script exists in package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the raw
pnpmcommands documented in the README with theirmakeequivalents, and adds the targets that were missing from the Makefile to make that possible.Changes
README
make start.make install/make build.make, and now points atmake helpfor the complete target list.make install.Makefile — three new targets:
stdiopnpm run stdio— the STDIO server fromdist/inspectornpx @modelcontextprotocol/inspector node dist/stdio-server.jstest-allpnpm test— the whole suite;make teststays unit-onlyNote on two dropped commands
The README documented
pnpm run dev("development mode with hot reload") andpnpm run inspector. Neither script exists inpackage.json, so both lines were stale. They are dropped rather than wrapped in a target:make inspectoruses the rawnpxinvocation the README already documented further down, so no capability is lost.tsx watch src/stdio-server.ts) — happy to add it in a follow-up.Verification
make helplists every target.make test-all→ 186 tests passing across 31 files.The one remaining
pnpmmention in the README is prose explaining that the package manager is only needed for local development — not a command, so it stays.