Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Site-Logo will be deleted on re-edit #1144

Closed
jensens opened this issue Oct 7, 2015 · 1 comment
Closed

Custom Site-Logo will be deleted on re-edit #1144

jensens opened this issue Oct 7, 2015 · 1 comment
Labels
01 type: bug 12 prio: high 21 status: confirmed 31 needs: help 42 lvl: moderate 99 tag: UX Site Admin
Milestone
Plone 5.0.x

Comments

@jensens
Copy link
Member

jensens commented Oct 7, 2015

After uploading the site logo in Site Settings control panel all is fine.
After editing the site settings again (w/o chnaging the logo), the logo will be overridden and the default Plone logo appears.
cc @thet
@jensens jensens added this to the Plone 5.0.x milestone Oct 7, 2015
@jensens
Copy link
Member Author

jensens commented Jan 18, 2016

this one is still valid

thet added a commit to plone/plone.formwidget.namedfile that referenced this issue Mar 8, 2016
@thet
Fix Custom Site-Logo will be deleted on re-edit
40f95a9 
Fix issue, where NamedFileWidget and NamedImageWidget on ``zope.schema.ASCII`` fields cleared the field values on resubmit with action ``nochange``.
Fixes: plone/Products.CMFPlone#1144

Introduces horrible doctest :/
z3c.form must die!
@thet thet mentioned this issue Mar 8, 2016
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 9, 2016
@jensens
[fc] Repository: plone.formwidget.namedfile
b7b099b 
Branch: refs/heads/master
Date: 2016-03-08T15:45:51+01:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/plone.formwidget.namedfile@40f95a9

Fix Custom Site-Logo will be deleted on re-edit
Fix issue, where NamedFileWidget and NamedImageWidget on ``zope.schema.ASCII`` fields cleared the field values on resubmit with action ``nochange``.
Fixes: plone/Products.CMFPlone#1144

Introduces horrible doctest :/
z3c.form must die!

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
Repository: plone.formwidget.namedfile
Branch: refs/heads/master
Date: 2016-03-09T12:35:37+01:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.formwidget.namedfile@ab41c20

Merge pull request #20 from plone/thet-fix-cmfplone1144

Fix Custom Site-Logo will be deleted on re-edit

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 9, 2016
@jensens
[fc] Repository: plone.formwidget.namedfile
8020af3 
Branch: refs/heads/master
Date: 2016-03-08T15:45:51+01:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/plone.formwidget.namedfile@40f95a9

Fix Custom Site-Logo will be deleted on re-edit
Fix issue, where NamedFileWidget and NamedImageWidget on ``zope.schema.ASCII`` fields cleared the field values on resubmit with action ``nochange``.
Fixes: plone/Products.CMFPlone#1144

Introduces horrible doctest :/
z3c.form must die!

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
Repository: plone.formwidget.namedfile
Branch: refs/heads/master
Date: 2016-03-09T12:35:37+01:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.formwidget.namedfile@ab41c20

Merge pull request #20 from plone/thet-fix-cmfplone1144

Fix Custom Site-Logo will be deleted on re-edit

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 9, 2016
@jensens
[fc] Repository: plone.formwidget.namedfile
59663a2 
Branch: refs/heads/master
Date: 2016-03-08T15:45:51+01:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/plone.formwidget.namedfile@40f95a9

Fix Custom Site-Logo will be deleted on re-edit
Fix issue, where NamedFileWidget and NamedImageWidget on ``zope.schema.ASCII`` fields cleared the field values on resubmit with action ``nochange``.
Fixes: plone/Products.CMFPlone#1144

Introduces horrible doctest :/
z3c.form must die!

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
Repository: plone.formwidget.namedfile
Branch: refs/heads/master
Date: 2016-03-09T12:35:37+01:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.formwidget.namedfile@ab41c20

Merge pull request #20 from plone/thet-fix-cmfplone1144

Fix Custom Site-Logo will be deleted on re-edit

Files changed:
M CHANGES.rst
M plone/formwidget/namedfile/tests.py
M plone/formwidget/namedfile/widget.py
M plone/formwidget/namedfile/widget.rst
M setup.py
@thet thet mentioned this issue Mar 9, 2016
Closed
@tkimnguyen tkimnguyen mentioned this issue May 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug 12 prio: high 21 status: confirmed 31 needs: help 42 lvl: moderate 99 tag: UX Site Admin
Projects
None yet
Milestone
Plone 5.0.x
Development

No branches or pull requests
2 participants
@jensens @thet