removed object_id and type from response #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged from master
Added new recording params and filter
cnam_lookup_number_config param added in getCallDetails api
* cnam_lookup in get and list * added buy number change * cnam lookup in update api * added my changes * handled -ve cases buy * sync with master logic (review changes) * sync with master logic (review changes) * added key validation * bump version * handled not found for get --------- Co-authored-by: kalyan-plivo <[email protected]>
* handling warnings * bump version
| } | ||
| if (isset($response['object_type'])) { | ||
| $this->properties['objectType'] = $response['object_type']; | ||
| } |
There was a problem hiding this comment.
@shubhankarPlivo Remove the same attributes from the numberGetResponse.json and numberListResponse.json file as well in the php
cc: @apoorv-plivo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.