Added null checks for api-id

plivo · Aug 1, 2023 · 60c5b1f · 60c5b1f
1 parent 9d6fd5a
commit 60c5b1f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Plivo/Resources/Verify/VerifySession.php b/src/Plivo/Resources/Verify/VerifySession.php
@@ -39,7 +39,6 @@ public function __construct(
         parent::__construct($client);
 
         $this->properties = [
-            'apiId' => $response['api_id'],
             'sessionUuid' => $response['session_uuid'],
             'appUuid' => $response['app_uuid'],
             'alias' => $response['alias'],
@@ -52,6 +51,10 @@ public function __construct(
         ];
 
         // handled empty string and null case
+        if (!empty($response['api_id'])) {
+            $this->properties['apiId'] = $response['api_id'];
+        }
+
         if (!empty($response['requestor_ip'])) {
             $this->properties['requesterIP'] = $response['requestor_ip'];
         }

diff --git a/src/Plivo/Resources/Verify/VerifySessionInterface.php b/src/Plivo/Resources/Verify/VerifySessionInterface.php
@@ -12,6 +12,7 @@
 use Plivo\Resources\ResourceInterface;
 use Plivo\Exceptions\PlivoNotFoundException;
 use Plivo\Resources\ResourceList;
+use Plivo\Resources\ResponseUpdate;
 
 /**
  * Class VerifySessionInterface
@@ -175,7 +176,7 @@ public function create($recipient, array $optionalArgs = [])
      *
      * @param string $sessionUuid
      * @param string $otp
-     * @return VerifySessionCreateResponse
+     * @return ResponseUpdate
      */
     public function validate($sessionUuid, $otp)
     {
@@ -212,10 +213,9 @@ public function validate($sessionUuid, $otp)
 
             );
         } else {
-            return new VerifySessionCreateResponse(
-                $responseContents['message'],
-                "",
+            return new ResponseUpdate(
                 $responseContents['api_id'],
+                $responseContents['message'],
                 $response->getStatusCode()
             );
         }