Explicitly make zip preamble options mutually exclusive
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--preamble`, `--preamble_from` and `--preamble_file` options to the `zip` command exhibit strange behaviour when more than one of them is specified. If `--preamble_file` and either of the other two options are given, the preamble from `--preamble`/`--preamble_from` will be written first, followed by the contents of `--preamble_file`. If `--preamble` and `--preamble_from` are given, only `--preamble_from` is honoured. If all three are specified, only `--preamble` and `--preamble_file` are honoured. It really only makes sense to use at most one of these options during a single invocation of the `zip` command, so exit in failure if more than one is specified.
peterebden
reviewed
Oct 17, 2024
peterebden
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--preamble,--preamble_fromand--preamble_fileoptions to thezipcommand exhibit strange behaviour when more than one of them is specified. If--preamble_fileand either of the other two options are given, the preamble from--preamble/--preamble_fromwill be written first, followed by the contents of--preamble_file. If--preambleand--preamble_fromare given, only--preamble_fromis honoured. If all three are specified, only--preambleand--preamble_fileare honoured.It really only makes sense to use at most one of these options during a single invocation of the
zipcommand, so exit in failure if more than one is specified.