Skip to content

Commit

Permalink
char: add missing NetWinder MODULE_DESCRIPTION() macros
Browse files Browse the repository at this point in the history
Since commit 1fffe7a ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. The following warnings are being
observed in drivers/char when CONFIG_ARCH_NETWINDER is enabled:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/ds1620.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/nwbutton.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/nwflash.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Jeff Johnson authored and gregkh committed Jul 31, 2024
1 parent f528cd5 commit d1009d0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/char/ds1620.c
Original file line number Diff line number Diff line change
Expand Up @@ -421,4 +421,5 @@ static void __exit ds1620_exit(void)
module_init(ds1620_init);
module_exit(ds1620_exit);

MODULE_DESCRIPTION("Dallas Semiconductor DS1620 thermometer driver");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions drivers/char/nwbutton.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ static void __exit nwbutton_exit (void)


MODULE_AUTHOR("Alex Holden");
MODULE_DESCRIPTION("NetWinder button driver");
MODULE_LICENSE("GPL");

module_init(nwbutton_init);
Expand Down
1 change: 1 addition & 0 deletions drivers/char/nwflash.c
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ static void __exit nwflash_exit(void)
iounmap((void *)FLASH_BASE);
}

MODULE_DESCRIPTION("NetWinder flash memory driver");
MODULE_LICENSE("GPL");

module_param(flashdebug, bool, 0644);
Expand Down

0 comments on commit d1009d0

Please sign in to comment.