Skip to content

Conversation

@willeastcott
Copy link
Contributor

  • Remove --camera-pos and --camera-target CLI options.
  • Add --viewer-settings option that exposes the documented viewer settings schema.

@willeastcott willeastcott self-assigned this Oct 11, 2025
@willeastcott willeastcott added the enhancement New feature or request label Oct 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces camera-specific CLI options with a flexible settings file approach for the HTML viewer, allowing users to configure all viewer settings through a JSON file rather than just camera position and target.

  • Removed --camera-pos and --camera-target CLI options
  • Added --viewer-settings option that accepts a JSON settings file
  • Updated documentation and help text to reflect the new configuration approach

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/writers/write-html.ts Implements JSON settings file loading and merging with default settings
src/index.ts Updates CLI argument parsing to use new viewer-settings option
README.md Updates documentation to reflect new settings file approach

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@willeastcott willeastcott merged commit c8f143b into main Oct 11, 2025
2 checks passed
@willeastcott willeastcott deleted the viewer-settings branch October 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants