Skip to content

Conversation

@slimbuck
Copy link
Member

@slimbuck slimbuck commented Sep 29, 2025

This PR:

  • updates the NaN/infinite filter to keep valid data:
    • opacity range is actually -inf...inf (which maps to 0...1 respectively)
    • scale range includes -inf (which maps to 0), inf is invalid.

@slimbuck slimbuck requested review from a team and Copilot September 29, 2025 11:07
@slimbuck slimbuck self-assigned this Sep 29, 2025
@slimbuck slimbuck added the bug Something isn't working label Sep 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the NaN/infinite value filter to preserve valid infinite values for specific data columns. The filter now correctly handles opacity and scale columns which have legitimate infinite value mappings.

  • Updates the filterNaN case to allow negative infinity for opacity and scale columns
  • Adds positive infinity support for opacity columns
  • Replaces generic object iteration with column-specific filtering logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slimbuck slimbuck changed the title Fix NaN filter Improve --filterNaN Sep 29, 2025
@slimbuck slimbuck merged commit 7d43f3d into playcanvas:main Sep 29, 2025
2 checks passed
@slimbuck slimbuck deleted the nan-fix branch September 29, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants