[NOT READY] Playwright #4752
Draft
[NOT READY] Playwright #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
playwright
branch
17 times, most recently
from
f0d886a
to
e2ad16a
Compare
macobo
force-pushed
the
playwright
branch
11 times, most recently
from
1fcbcd5
to
ee1c6c7
Compare
This was causing non-determinism
|
Good idea to have e2e tests! Since you mentioned having issues with the seeded data, how about we run it without seeded data? We could run a mock website at localhost:80 with a particular version of the tracker script installed. Tests would look something like:
|
|
Note that this PR is not ready yet - I will open it up as a proposal once it is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore for now.