Map lowercase tagged sources to capitalized form during ingestion #4417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This work is in preparation of a bigger project - Acquisition Channel.
This PR changes how we handle manually tagged acquisition data. When links are manually tagged, usually the
utm_source
parameter has a value likegoogle
orfacebook
. However, when we automatically detect sources based on the Referer header, we store thesource
field asGoogle
orFacebook
. So then we have dashboards that have both sourcesgoogle
andGoogle
where the first is manually tagged traffic and the second is automatically detected.However, both are coming from the same source so we would like to merge the lowercase and the capitalized entry in sources.
The way I've decided to tackle it here is to build a lookup table from the
RefInspector
library that stores all sources in a table like:We use this table to lookup
google -> Google
during ingestion, for example.The logic is that if the manually passed
utm_source
matches the lowercase form of any known traffic source, it gets transformed and stored as the capitalized form like automatically added sources.We have also discussed a data migration for historical data to apply the same transformation. I'll look into that next.
Tests
Changelog
Documentation
Dark mode