does_not_contain, new filters wildcard matching
#4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
multiple-filters-fe-3
branch
from
0aff5b5
to
78d4a28
Compare
macobo
added
the
deploy-to-staging
macobo
force-pushed
the
multiple-filters-fe-3
branch
2 times, most recently
from
f7a32fe
to
5e18517
Compare
|
@ukutaht updated the modal to render nicer (found the extra 3px):
Also removed the flag as discussed in the call |
ukutaht
approved these changes
Jun 20, 2024
Found 3 extra pixels for operation dropdown
macobo
force-pushed
the
multiple-filters-fe-3
branch
from
5e18517
to
127c707
Compare
macobo
added a commit
that referenced
this pull request
Jun 21, 2024
Previous PR #4228 Changelog wasn't correctly updated. This fixes that issue
Merged
macobo
added a commit
that referenced
this pull request
Jun 21, 2024
Previous PR #4228 Changelog wasn't correctly updated. This fixes that issue
ruslandoga
pushed a commit
that referenced
this pull request
Jun 23, 2024
* Make goals accept wildcards in :is queries * Add support for contains/does_not_contains in the backend * Support all operations for event custom properties * Support does_not_contain on the frontend * Changelog entry * Render filter operations nicely for does not contain Found 3 extra pixels for operation dropdown * Remove multiple_filters feature flag
ruslandoga
pushed a commit
that referenced
this pull request
Jun 23, 2024
Previous PR #4228 Changelog wasn't correctly updated. This fixes that issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on #4227, separate PR for easier reviewability
This PR:
event:goalmatching support to work with wildcardsdoes_not_containoperation to the backend and frontendcontaininstead ofmatcheswhen querying the backend.Related request: https://feedback.plausible.io/249
Tests
Changelog