Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queries with wildcard goals #3015

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix queries with wildcard goals #3015

merged 2 commits into from
Jun 14, 2023

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Jun 8, 2023

Changes

Fixes DB queries in case where multiple wildcard page goal filters are used, but no custom event goal is included in the filter.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@bundlemon
Copy link

bundlemon bot commented Jun 8, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
304.55KB -
static/js/app.js
12.31KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vinibrsl vinibrsl merged commit 98055d2 into master Jun 14, 2023
6 checks passed
@vinibrsl vinibrsl deleted the fix-wildcard-goals branch June 14, 2023 13:14
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* Fix queries with wildcard goals

* Changelog
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* Fix queries with wildcard goals

* Changelog
ruslandoga pushed a commit to ruslandoga/plausible that referenced this pull request Jul 10, 2023
* Fix queries with wildcard goals

* Changelog
ruslandoga pushed a commit that referenced this pull request Jul 12, 2023
* Fix queries with wildcard goals

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants