Add referrers.csv to CSV export (#2624)

[kiote]

Changes

Added a new file: referrers.csv to statsController. That also required to create a new function in stats controller API (or, maybe I didn't realize how to re-use existing functions). Before only referrer_drilldown function was presented, which requires a particular referrer.

Tests

• Automated tests have been added
• This PR does not require tests

Changelog

• Entry has been added to changelog
• This PR does not make a user-facing change

Documentation

• Docs have been updated
• This change does not need a documentation update

Dark mode

• The UI has been tested both in dark and light mode
• This PR does not change the UI

[ukutaht]

Thanks @kiote!

I think this PR definitely needs tests to prevent regressions before we can review and approve. We have some existing tests for exported CSVs here.

[kiote]

hey @ukutaht , thanks for checking. What kind of tests you have in mind? currently what I see, there is a check that .zip file with all csv files created, but no test on separate files.. should I create the first one?

[bundlemon]

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	static/js/dashboard.js	320.33KB (+265B +0.08%)	-

Unchanged files (6)

Status	Path	Size	Limits
✅	static/css/app.css	492.34KB	-
✅	static/js/app.js	40.11KB	-
✅	static/js/embed.host.js	5.58KB	-
✅	static/js/embed.content.js	5.08KB	-
✅	tracker/js/plausible.js	742B	-
✅	static/js/applyTheme.js	314B	-

Total files change +265B +0.03%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[ukutaht]

There are a few tests for CSV exports in test/plausible_web/controllers/stats_controller_test.exs

I've enabled CI on this PR and it shows that the existing tests are failing. I think extending the tests that are currently failing would provide good test coverage.

[kiote]

Ah, I see. Will look into it, thanks!

[kiote]

Hi @ukutaht can you please have a look again? I fixed failing tests, and also got a bit better understanding of the code 💪

[kiote]

hi @ukutaht, what are the next steps with this?

[aerosol]

@kiote hey 👋, sorry for the delay on that one. If you could rebase your PR I'm going to merge it. We'll also need Browser/OS versions in the export. Is that something you'd be interested in working on? I have some capacity the coming days so I'll be happy to assist.

[kiote]

Hey I've made a merge with master, which as I realise afterwards was not exactly the same as rebase you wanted :D
So what should I do now?

Also would be happy to continue with Browser/OS versions since I have some grasp in it already

[aerosol]

Hey I've made a merge with master, which as I realise afterwards was not exactly the same as rebase you wanted :D
So what should I do now?

Excellent. thank you!
Same thing effectively, since we squash to master anyway :)

Also would be happy to continue with Browser/OS versions since I have some grasp in it already

Awesome, looking forward to it!

[aerosol]

@kiote something's wrong though: https://github.com/plausible/analytics/actions/runs/5748420928/job/15658447728?pr=3002

[kiote]

Looks like the merge didn't go as planned. Sorry for that, will try again soon

[kiote]

ok seems like some renaming was made in master, now I followed it too in this PR. Should be better now! Could you please re-try the tests

[aerosol]

Nice, thank you.
Your next PR should kick off CI automatically I hope.