-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternative mailing services (Mailgun, Mandrill, Sendgrid) #2649
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
88b5003
to
e37638e
Compare
"Bamboo.MailgunAdapter" -> | ||
config :plausible, Plausible.Mailer, | ||
adapter: Bamboo.MailgunAdapter, | ||
hackney_opts: [recv_timeout: :timer.seconds(10)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find request_options
in bamboo. It seems to be specific to bamboo_postmark
So I used hackney_opts
in the built-in adapters.
05c0829
to
237fab9
Compare
2d9b2db
to
b5bc0f1
Compare
b5bc0f1
to
5a68670
Compare
Hi folks, In my case I was looking at using this for Mailgun, unfortunately I don't think this will work for folks who use Mailgun's EU servers. I had a look at the source code for the implementation, and you might need to add the You can read more about this in the Bamboo Adapter docs here. I'll try to put a comment inline to the PR as well. Do let me know if you want me to create a new issue for this. I felt it was important to include this as this is included in the v2 RC and it would be great to have this fix included. Of course I might have gotten this completely wrong and if so apologies in case the |
Changes
This PR is similar to #2596 but hardcodes all adapters that bamboo ships with and adds some config tests.
Tests
Changelog
Documentation
Dark mode