Fix shared link with bad auth #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
vinibrsl
approved these changes
Sep 14, 2022
aerosol
reviewed
Sep 14, 2022
aerosol
reviewed
Sep 14, 2022
ukutaht
force-pushed
the
fix-shared-link-with-bad-auth
branch
from
9210788
to
292bfeb
Compare
|
Updated, now using |
|
aerosol
reviewed
Sep 20, 2022
| @@ -115,7 +115,7 @@ defmodule Plausible.MixProject do | |||
| {:telemetry, "~> 1.0", override: true}, | |||
| {:timex, "~> 3.7"}, | |||
| {:ua_inspector, "~> 3.0"}, | |||
| {:ex_doc, "~> 0.28"} | |||
| {:ex_doc, "~> 0.28", only: :dev, runtime: false} | |||
ukutaht
force-pushed
the
fix-shared-link-with-bad-auth
branch
from
e9ee194
to
fa7799d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This work started as a bug fix for a Sentry error. I used the opportunity for some refactoring & docs as well.
Plausible.StatsController.shared_link/2for clarityDuring development I found that backwards compatibility for the older format of shared links was broken in this commit.
Tests
Changelog
Documentation
Dark mode