Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint-plugin-unicorn to v37 #210

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Upgrade eslint-plugin-unicorn to v37 #210

merged 2 commits into from
Oct 15, 2021

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Oct 11, 2021 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 73cfa6e on bmish:eslint-plugin-unicorn-v37 into d04fce1 on platinumazure:master.

@coveralls
Copy link

coveralls commented Oct 11, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a06a363 on bmish:eslint-plugin-unicorn-v37 into d04fce1 on platinumazure:master.

platinumazure
platinumazure requested changes Oct 15, 2021
View reviewed changes
Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are warnings from the lint run. Could we either fix the issues, or explicitly turn the rule off in config? Thanks!

@bmish
Copy link
Collaborator Author

bmish commented Oct 15, 2021

Autofixed the warnings.

@platinumazure platinumazure merged commit 6780964 into platinumazure:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmish @coveralls @platinumazure