Fix environments listing by ID

platformsh · Sep 17, 2024 · 837fff6 · 837fff6
1 parent 8f3b65b
commit 837fff6
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Service/Api.php b/src/Service/Api.php
@@ -745,13 +745,14 @@ public function getEnvironments(Project $project, $refresh = null, $events = tru
         if ($refresh === false && !$cached) {
             return [];
         } elseif ($refresh || !$cached) {
-            $toCache = [];
-
             // Fetch environments with double the default timeout.
-            $environments = Environment::getCollection($project->getLink('environments'), 0, [
+            $list = Environment::getCollection($project->getLink('environments'), 0, [
                 'timeout' => 2 * $this->config->getWithDefault('api.default_timeout', 30),
             ], $this->getHttpClient());
-            foreach ($environments as $environment) {
+            $environments = [];
+            $toCache = [];
+            foreach ($list as $environment) {
+                // Key the list by ID.
                 $environments[$environment->id] = $environment;
                 $toCache[$environment->id] = $environment->getData();
             }