Changing library priority #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, agree that it would be better for local versions to override the platform default. |
ivankravets
added a commit
that referenced
this pull request
Jan 29, 2015
|
@MrCustomizer can you retest it with the latest $ pip uninstall platformio
$ pip install https://github.com/ivankravets/platformio/archive/develop.zipThanks a lot! |
|
Thank you so much! I've tested it on Linux and Windows and it's working on both systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, that the order, in which libraries are passed to Scons, is relevant. The current order has the following disadvantage: If there are two versions of the same library, one located in lib_dir and one located in the platform directory, the library in the platform directory has precedence over the library in lib_dir (at least on my system). I think it should be exactly the other way round.
An example:
We use a modified version of the library SoftwareSerial and have placed the modified version in lib_dir, which resides in our project repository. The original version of SoftwareSerial is still present in /usr/share/arduino/libraries, which is the platform lib directory. When we build our project, the modified version of SoftwareSerial should be used, not the original one.
My proposal for a solution:
Switch the order, in which the library paths are passed to Scons. This works on my Linux and Windows system. But I'm not sure, if this change can have other side effects. What is your opinion?