-
-
Notifications
You must be signed in to change notification settings - Fork 799
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix invalid detecting of compiler type // Resolve #550
- Loading branch information
1 parent
c9505b3
commit 8388359
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8388359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hitting a problem with this commit right now: the 'clang' check never succeeds. This is because
output
is cast to lowercase and there is a check for the string"LLVM"
(which is in uppercase).I'm working on a Clang-based platform that doesn't support
--start-group
and--end-group
, but the compiler is always recognized as GCC (not Clang) so-Wl,--start-group
and-Wl,--end-group
is inserted.8388359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a fix: #4897