Skip to content

Conversation

@bsatrom
Copy link
Contributor

@bsatrom bsatrom commented Mar 22, 2023

No description provided.

@valeros
Copy link
Member

valeros commented Mar 22, 2023

Hi @bsatrom, thanks for the PR. Shouldn't a proper variant be added to https://github.com/stm32duino/Arduino_Core_STM32 in the first place?

@bsatrom
Copy link
Contributor Author

bsatrom commented Mar 22, 2023

@valeros 🤦 yep, you are correct. I will take care of that first and let you know when it's done.

@bsatrom
Copy link
Contributor Author

bsatrom commented Mar 29, 2023

PR submitted here: stm32duino/Arduino_Core_STM32#1987

@bsatrom
Copy link
Contributor Author

bsatrom commented Mar 31, 2023

@valeros PR above is approved and set to merge pending CI results. Slated for the 2.6.0 release.

@diplodocuslongus
Copy link

@bsatrom @valeros hi, so it seems the current version of platform-ststm32 still doesn't support sparkfun micromod stm32f405 chips, is there any issue regarding Brandon's work to be merged here?
Sparkfun micromod STM32 boards are supported in:
https://github.com/stm32duino/Arduino_Core_STM32#sparkfun-boards

Brandon, I've tried your fork with the following setting in my platformio.ini:

platform = https://github.com/bsatrom/platform-ststm32.git
board = sparkfun_micromod_f405
framework = arduino

But a simple blink example build fails by complaining it can't find variant_SPARKFUN_MICROMOD_F405.h. Is there anything else I need to install?

@bsatrom
Copy link
Contributor Author

bsatrom commented Sep 1, 2023

Hey @diplodocuslongus I suspect that there needs to be an additional change to this PR to support Arduino core 2.6.0, see here for the 2.5.0 bump. I'll update this, but if you want to try yourself, open platform.json and change line 195 to

"version": "~4.20600.0"

@valeros valeros merged commit 77319ce into platformio:develop Sep 19, 2023
@valeros
Copy link
Member

valeros commented Sep 19, 2023

Thanks for the PR, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants