Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adafruit feather M4 CAN does not upload #167

Closed
mansk789 opened this issue Aug 5, 2021 · 5 comments
Closed

Adafruit feather M4 CAN does not upload #167

mansk789 opened this issue Aug 5, 2021 · 5 comments
Labels

Comments

@mansk789
Copy link

mansk789 commented Aug 5, 2021

samE_Patch.zip
there seems to be an issue with the adafruit feather m4 CAN board and uploading. bossac-tool complains "bossac: extra arguments found".

First it seems like the port is not passed correctly to the bossac tool. It passes it as --port "ttyACM0" while it should be --port=ttyACM0

The second problem I found, there is no offset passed to the bossac-tool. this is due to the main.py L220:
if board.get("build.core") in ("adafruit", "seeed", "sparkfun") and board.get( "build.mcu").startswith("samd51"):

In my opinion it should be:
if board.get("build.core") in ("adafruit", "seeed", "sparkfun") and (board.get( "build.mcu").startswith("samd51") or board.get("build.mcu").startswith("same51")):

@pauljeffress
Copy link

Looks like may be same as this issue?
#160

@mansk789
Copy link
Author

mansk789 commented Aug 6, 2021

Looks like may be same as this issue?
#160

No this seems to be another issue. They got the error No device found on COM5 *** [upload] Error 1

My error is bossac: extra arguments found

@valeros
Copy link
Member

valeros commented Aug 9, 2021

Hi @mansk789 , thanks for reporting! I've just pushed a fix and now the offset value should be also used for SAM E51. I believe this should also fix your first problem with the bossac: extra arguments found error. Could you please try to run your project using the upstream version of the platform (a Git client is required):

[env:adafruit_feather_m4_can]
platform = https://github.com/platformio/platform-atmelsam.git
board = adafruit_feather_m4_can
framework = arduino

@valeros valeros added the bug label Aug 9, 2021
@mansk789
Copy link
Author

mansk789 commented Aug 9, 2021

Hi @valeros
Works like a charm, thanks for the quick fix! Do you have already a timeline, when the fix will be in the production code? (just for my info, no rush :) )

@valeros
Copy link
Member

valeros commented Aug 10, 2021

Thanks for confirming, a new release will be published by the end of this week.

Resolved in 2c92f8a

@valeros valeros closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants