Shut down profiler thread when no more threads are being sampled #228
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
suggested changes
Jun 26, 2024
| @@ -223,6 +227,7 @@ class profiler { | |||
| spinlock _latency_points_lock; //< Spinlock that protects the latency points map | |||
|
|
|||
| static_map<pid_t, thread_state> _thread_states; //< Map from thread IDs to thread-local state | |||
| uint64_t _num_threads_running; //< Number of threads that are currently being sampled | |||
There was a problem hiding this comment.
This should be atomic since it's shared across threads. uint64_t is also inconsistent with the other integer sizes used here.
Suggested change
| uint64_t _num_threads_running; //< Number of threads that are currently being sampled | |
| std::atomic<size_t> _num_threads_running; //< Number of threads that are currently being sampled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #227