AddComponentTag uses component font by default#246
Merged
kirchsth merged 1 commit intoplantuml-stdlib:masterfrom Oct 20, 2022
Merged
AddComponentTag uses component font by default#246kirchsth merged 1 commit intoplantuml-stdlib:masterfrom
kirchsth merged 1 commit intoplantuml-stdlib:masterfrom
Conversation
Use $COMPONENT_FONT_COLOR as the default $fontColor for AddComponentTag and AddExternalComponentTag. Otherwise, tagged components have an unexpected (non-default) font color even when no font color was passed to AddComponentTag.
kirchsth
approved these changes
Oct 20, 2022
Member
kirchsth
left a comment
kirchsth
left a comment
There was a problem hiding this comment.
Thank you for the fix
BR Helmut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use $COMPONENT_FONT_COLOR as the default $fontColor for AddComponentTag and AddExternalComponentTag. Otherwise, tagged components have an unexpected (non-default) font color even when no font color was passed to AddComponentTag.